search

cribeiro84 / azure-devops-pull-request-hub

Azure DevOps Pull Request Manager Hub
MIT License
59 stars 35 forks source link

Displaying Aproval of a group when the PR author is part of the group #146

Open jonatancompiani opened 4 years ago

jonatancompiani commented 4 years ago

If the author of PR is part of a reviewer group which is Required, the reviewer group appears as having approved the PR, even if the approval is from the author.

Disclaimer I opened this issue having in mind one should not have a weight of reviewer on its own PR, but it could be different for some projects, so it could be configurable maybe?

Wrongly displayed approval image

PR Policies and reviewers image

jonatancompiani commented 4 years ago

Unfortunately this is still happening after the last update.

I tested in two different browsers, after clearing the cache. image

cribeiro84 commented 4 years ago

@jonatancompiani there is a new validation that must be done to handle when the requester can approve its own PR.