search

cribeiro84 / azure-devops-pull-request-hub

Azure DevOps Pull Request Manager Hub
MIT License
59 stars 35 forks source link

Decline to review doesnt change PRMH main screen #210

Open philippedurocher opened 3 years ago

philippedurocher commented 3 years ago

Describe the bug When I decline to review a PR, my avatar should be marked as declined on the main screen hub but it's still appears as if waiting for my review.

To Reproduce Steps to reproduce the behavior:

  1. Go to in a PR where you a reviewer
  2. Click on Decline to review
  3. Go back to PRMH main screen
  4. The avatar is still showing with a blue aura and a clock icon, as if waiting for my review
  5. The tooltip when hovering avatar is showing No Vote

Expected behavior

  1. Add a red aura + an red+white exclamation mark icon to show reviewer declined to review
  2. Adjust tooltip to show Declined to review

ps: I tried to follow the instructions in main page to try and fix myself and make a PR but I can't figure out how to make it compile/work.

cribeiro84 commented 3 years ago

Thanks @philippedurocher for raising this issue. I couldn't reproduce the issue from my end. Whenever the PR is rejected and you go back to PRMH and refreshes it, it does shows in the Reviewers column the red aura.

Example: image

Would you be able to give me more details or perhaps to provide a small video of the issue?

Many thanks and sorry for the inconvenience.

philippedurocher commented 3 years ago

no-decline2review-icon

As you can see in the animated gif, icon is still blue after declining to review.

Thank you!

cribeiro84 commented 3 years ago

@philippedurocher - Now I got the point, actually, when you "decline" to remove, the approval status doesn't change. It will only show/change the icon if you Reject the PR. I didn't consider the decline option, maybe it can become an enhancement for the PRMH ;-)

philippedurocher commented 3 years ago

That would be great thank you! I really love your tool.

jamesptk commented 1 year ago

Not sure if this counts as a separate enhancement or not (would be happy to raise it as one if you want), but it would be incredibly useful for me to be able to exclude decline to review from the list.

My use case is that I use a standard set of filters: I show only PRs from my teams, that I have not given an approval on and are not draft. That then shows me all PRs that I should approve, or in cases where I opened them, that I should get approved - the object, of course, is to get an empty list.

Sometimes, however, there is a PR that I don't have enough context on, or in a language I am not familiar enough in, which I won't review, but there is no way for me to remove this from the list