cribeiro84 / azure-devops-pull-request-hub

Azure DevOps Pull Request Manager Hub
MIT License
57 stars 35 forks source link

Bugfix/203 sorting resets on refresh #243

Closed Xerillio closed 1 year ago

Xerillio commented 1 year ago

Fixes #203 by storing the sorting direction in the state object. This means on a table refresh the sorting direction is rememberd instead of falling back to the default sorting from the user preferences. This was causing the sorting icon (arrow) to be opposite of the actual sorting applied.

On a whole page refresh or switching between tabs (Active, Recently Completed, Recently Abandoned) the sorting is still reset as usual.

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging 3b50066b2d0e7466aa63bb6238f19b3724970879 into d1c3d69ec86abb85912afff215f3145fb8640bc9 - view on LGTM.com

new alerts:

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

cribeiro84 commented 1 year ago

@Xerillio - the PR looks great, would you mind just to check the error on NodeJS CI build? It seems there is an unused reference.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Xerillio commented 1 year ago

@cribeiro84 Ah yes, should be fixed now!

cribeiro84 commented 1 year ago

@Xerillio just to let you know, I am trying to fix an issue for the extension pipeline that's broken due an issue to install the TFX tool on the agent. It seems Microsoft changed the tool or its version..

cribeiro84 commented 1 year ago

It's now fixed! New version has been published... thanks for your PR @Xerillio :-)