cribeiro84 / azure-devops-pull-request-hub

Azure DevOps Pull Request Manager Hub
MIT License
60 stars 35 forks source link

Don't reuse the already loaded repositories #252

Open davesmits opened 1 year ago

davesmits commented 1 year ago

An attempt to get #241 fixed

I noticed two faulty behaviors:

This change should reset the items in the state instead of just keep adding more and more

DISCLAIMER: So far not been able to test it locally.. which makes it a bit of a risky change. Maybe a maintainer can give me a hand?

cribeiro84 commented 1 year ago

@davesmits thanks for raising this PR, I will try to look into it in the following days. It's breaking the build due the invalid variable declaration.

davesmits commented 1 year ago

I gave it another try but don't understand what is wrong and build results in missing file. So hope you want to help

image
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

davesmits commented 1 year ago

@cribeiro84 want to give it another look? should be building now again

davesmits commented 3 weeks ago

@cribeiro84 anything I can to do to get this merged or fixed?

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cribeiro84 commented 3 weeks ago

@cribeiro84 anything I can to do to get this merged or fixed?

was this tested on your environment? Did you see any impact?

davesmits commented 3 weeks ago

I will give it a renew try this weekend. not sure where I left it off.