cribeiro84 / azure-devops-pull-request-hub

Azure DevOps Pull Request Manager Hub
MIT License
59 stars 35 forks source link

User icons have stopped working #281

Open StuartMc77 opened 4 months ago

StuartMc77 commented 4 months ago

In Chrome, the icons that represent the users are only showing the "broken image" icon. The only way to tell who is a reviewer is to hover the mouse over the icon to show the name. I've tried in an Incognito window also. It seems to be working in Edge

When I inspect the html element the image src url is correct and when copied into a new tab will load the image correctly.

image

Desktop (please complete the following information):

MrDark commented 1 month ago

I have the same issue with Firefox 131.0.3

image

StuartMc77 commented 1 month ago

@MrDark - I did resolve this in the end. I forgot to update this ticket. It turned out to be an issue with permissions. Sadly I cannot remember exactly which. I worked out by looking at the dev tools and I could see the error messages when it was trying to load the icons.

Hope this helps you mate.

MrDark commented 1 month ago

Do you remember if it was a DevOps or browser permission?

I'm the org and project admin, so one would think I have permission to load someone's profile picture.

Looking at the network panel, it seems the profile picture images are being redirected to the sign-in portal. When I open the image URL in a new tab, I see the redirect, but after that, the user icon shows fine.

https://spsprodweu1.vssps.visualstudio.com/_signin?realm=dev.azure.com&reply_to=https://dev.azure.com/xxxxxxxxxxx/_apis/GraphProfile/MemberAvatars/aad.YTI0M2MzZDItMTg4Zi03OTIxLTk3OTktNGFmXXXXXXXXX&redirect=1&hid=ab3dbe84-00a4-4cfb-b2ee-1183f105e045&context=eyJodCI6MiwiaGlkIjoiYmXXXXXXXXXXXWUzMi00YzQ1LTllYTQtZWQ0N2ViZjQ0OGQxIiwicXMiOnt9LCJyciI6IiIsInZoIjoiIiwiY3YiOiIiLCJjcyI6IiJ90

image

StuartMc77 commented 1 month ago

It was a devops thing, that I can remember. I'm wondering if it was something to do with the extension permissions. Sorry that I can't recall what I did to fix it... my memory is terrible at times.

On Mon, 28 Oct 2024 at 13:59, Danny @.***> wrote:

Do you remember if it was a DevOps or browser permission?

I'm the org and project admin, so one would think I have permission to load someone's profile picture.

Looking at the network panel, it seems the profile picture images are being redirected to the sign-in portal. When I open the image URL in a new tab, I see the redirect, but after that, the user icon shows fine.

https://spsprodweu1.vssps.visualstudio.com/_signin?realm=dev.azure.com&reply_to=https://dev.azure.com/xxxxxxxxxxx/_apis/GraphProfile/MemberAvatars/aad.YTI0M2MzZDItMTg4Zi03OTIxLTk3OTktNGFmXXXXXXXXX&redirect=1&hid=ab3dbe84-00a4-4cfb-b2ee-1183f105e045&context=eyJodCI6MiwiaGlkIjoiYmXXXXXXXXXXXWUzMi00YzQ1LTllYTQtZWQ0N2ViZjQ0OGQxIiwicXMiOnt9LCJyciI6IiIsInZoIjoiIiwiY3YiOiIiLCJjcyI6IiJ90

image.png (view on web) https://github.com/user-attachments/assets/70c1b074-4618-4416-b344-5e05d525c5e0

— Reply to this email directly, view it on GitHub https://github.com/cribeiro84/azure-devops-pull-request-hub/issues/281#issuecomment-2441671432, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKEIQ4YGOUOV5RBWXSQJPZ3Z5YYMPAVCNFSM6AAAAABL4DVWCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBRGY3TCNBTGI . You are receiving this because you authored the thread.Message ID: @.*** com>

--

Kind regards

Stuart McIntosh

MrDark commented 1 month ago

Found the solution! Firefox "Enhanced Tracking Protection" breaks it. Turning this feature off for Azure DevOps made the user icons show. image

doormalena commented 2 weeks ago

Thanks for sharing! In Edge this seems related to allowing "Third-party cookies". This works. I was already getting more annoyed by the day of this issue. Great timing :-).

image

StuartMc77 commented 2 weeks ago

Same on chrome. It happened again to me last week. Chrome only allows third party cookies for 90 days, it seems, before you have to authorise it again.

On Tue, 26 Nov 2024 at 14:19, Alexander @.***> wrote:

Thanks for sharing! In Edge this seems related to allowing "Third-party cookies".

image.png (view on web) https://github.com/user-attachments/assets/4fd460ff-7f80-4aee-9d80-4d053e580dad

— Reply to this email directly, view it on GitHub https://github.com/cribeiro84/azure-devops-pull-request-hub/issues/281#issuecomment-2500926954, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKEIQ46QLYG7UG3T3MYOEM32CR7QZAVCNFSM6AAAAABL4DVWCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBQHEZDMOJVGQ . You are receiving this because you authored the thread.Message ID: @.*** com>