search

criccomini / proto-schema-parser

A Pure Python Protobuf Parser
MIT License
38 stars 20 forks source link

Preserve comments in AST #12

Closed jpihl closed 8 months ago

jpihl commented 8 months ago

Hi there,

I've been exploring tools for parsing proto files to extract documentation from messages and fields, and I found your cool project. I like the simplicity, but for my use case, I need to access the comments in the proto files as well - this PR solves that. I don't know if this is something you think is within the scope of your project, but here goes.

All the best,

Jeppe

criccomini commented 8 months ago

Woah, this is great!! Definitely happy to add this functionality. Only concern is that we're modifying the Buf lex files. Just means we'll have to merge their changes in if they make any. Not a huge deal. Let me take a look at the PR and get back to you.

criccomini commented 8 months ago

Merged! Released in 1.1.0