Allow optional semicolon termination on block method declarations

[joshuaghezzi]

• method block declarations can also end with semicolons like

  service ExampleService {
    rpc MyMethod_Semicolon(RequestType) returns(ResponseType) {
        option (my_method_option).foo = 567;
        option (my_method_option).bar = "Some string";
    };
  }

[criccomini]

I don't believe that trailing semicolons on blocks are valid Protobuf syntax.

From GPT4:

From the Buf proto language spec:

Block declarations: A block declaration is used for composite elements: those that may contain other elements. Instead of ending with a semicolon, they end with a block enclosed in braces ({ and }). The contained elements are defined inside these braces.

This appears to apply for both proto2 and proto3. As such, I'm inclined to reject this PR.

[joshuaghezzi]

I would disagree with the GPT4 output, I believe they are valid optional syntax. At least in terms of being able to compile that is.

Unfortunately if this is not supported this package would be unusable for my use case as our proto method block declarations do end with a semicolon.

[criccomini]

What are you using to codegen from the protos? It's possible that Buf's spec is incorrect--it's not canonical. protoc is canonical.

[joshuaghezzi]

Yeah seems like it could be the case. Just using protoc to generate source code.

[criccomini]

Ok, let's merge it. Unfortunately, there's a merge conflict. Can you rebase for me?

[criccomini]

Merged and released in 1.3.2!

https://pypi.org/project/proto-schema-parser/1.3.2/

[criccomini]

Thanks ❤️