search

criccomini / proto-schema-parser

A Pure Python Protobuf Parser
MIT License
38 stars 20 forks source link

Closing " at end of comment line not included #32

Closed johan-groenenboom closed 2 weeks ago

johan-groenenboom commented 3 weeks ago

I noticed that a comment such as:
// rpc_response_type = "test/types/v1/test_response.proto"
will have a node.text equal to:
// rpc_response_type = "test/types/v1/test_response.proto
This means for instance, that removing comments from the original text based on the collection of comment nodes does not work.

(tested with 1.3.5 and 1.3.7)

criccomini commented 2 weeks ago

Fixed and released in 1.3.8:

https://pypi.org/project/proto-schema-parser/1.3.8/

johan-groenenboom commented 2 weeks ago

Thanks for the blazingly fast response, it works correctly now!