search

crichtan / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

FPDF_FORMFILLINFO should use float instead of double to avoid conversions and casts #104

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
FPDF_FORMFILLINFO::FFI_GetPageViewRect (and other functions declared in 
fpdfformfill.h) use double. This forces FFI_GetPageViewRect to use double, 
which then forces casts to float in order to suppress truncation warnings.

One type should be used consistently (presumably float) and the casts should be 
removed.

See change https://codereview.chromium.org/834413002/ which added the casts in 
order to suppress warnings.

Original issue reported on code.google.com by brucedaw...@chromium.org on 8 Jan 2015 at 7:07