crichtan / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

Windows x64 pdfium gyp build fails with ninja #22

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. Set GYP to generate ninja build files:

set GYP_GENERATORS=ninja

2. Try to generate the ninja build files for x64:

python build/gyp_pdfium -Dtarget_arch=x64

What is the expected output? What do you see instead?

ninja build files should be generated for Windows x64 but gyp bails out with 
"KeyError: 'Debug_x64'" instead.

This is a similiar issue as skia issue 2348:
https://code.google.com/p/skia/issues/detail?id=2348

What version of the product are you using? On what operating system?

gyp r1939, pdfium 9d319f0cb5e0850447dbd95b07fed28245fb0b31, ninja 1.4.0 on 
windows.

Please provide any additional information below.

This problem can be fixed similarly to the skia issue using the attached patch. 
I will submit a cl with this patch as well.

Original issue reported on code.google.com by m.dopp...@gmail.com on 1 Jul 2014 at 11:38

Attachments:

GoogleCodeExporter commented 9 years ago
Code Review submitted under:

https://codereview.chromium.org/360273002/

Original comment by m.dopp...@gmail.com on 1 Jul 2014 at 11:41

GoogleCodeExporter commented 9 years ago
Fix landed. Someone with bug editing permissions can mark this Fixed.

Original comment by thakis@chromium.org on 17 Jul 2014 at 4:04

GoogleCodeExporter commented 9 years ago
Thanks Doppler and thakis! This is fixed in 
https://pdfium.googlesource.com/pdfium/+/c7cd3c82b1c77443756edb2708d5273f397f00c
8

Original comment by bo...@foxitsoftware.com on 17 Jul 2014 at 5:19