search

crigroup / openrave-installation

Bash scripts to install OpenRAVE from source
164 stars 77 forks source link

Add support for ubuntu 20.04 #16

Closed leonardoedgar closed 3 years ago

leonardoedgar commented 3 years ago

Tested in a docker container

nicholasadr commented 3 years ago

Cool! I notice that this commit upgrades the script compatibility to newer versions of Ubuntu and OpenRAVE (production branch I assume?). Out of curiosity, which changes are intended for the Ubuntu distro upgrade and which are for upgrading the OpenRAVE version? Asking in case I want to do different installation combination, e.g. Ubuntu 18 + OpenRAVE 0.53

leonardoedgar commented 3 years ago

Cool! I notice that this commit upgrades the script compatibility to newer versions of Ubuntu and OpenRAVE (production branch I assume?). Out of curiosity, which changes are intended for the Ubuntu distro upgrade and which are for upgrading the OpenRAVE version? Asking in case I want to do different installation combination, e.g. Ubuntu 18 + OpenRAVE 0.53

Yes, it is one of the latest commit from the production branch (just committed this week). For now the script only allows the following configs:

There is only 1 OpenRAVE version for each OS, so the user will not have any options to select which OpenRAVE version to install in one OS.

nicholasadr commented 3 years ago

I haven't had the time to look into this but given the recent review it seems that it's good to go. Let me know if you want me (or anyone else) to merge it @leonardoedgar ?

leonardoedgar commented 3 years ago

I haven't had the time to look into this but given the recent review it seems that it's good to go. Let me know if you want me (or anyone else) to merge it @leonardoedgar ?

I think we can merge this to master already.

nicholasadr commented 3 years ago

Thanks @leonardoedgar @mstallone, i'll merge this