search

crim-ca / decision-support-tool

0 stars 1 forks source link

Changed debug flag to false (fixes final presentation style) #1

Closed JeremyFyke closed 2 years ago

JeremyFyke commented 2 years ago

hi @matprov - this is a simple pull request to fix the ugly progressbar issue you highlighted.

matprov commented 2 years ago

@JeremyFyke Accepted, you can merge when ready.

JeremyFyke commented 2 years ago

Hi @matprov - in prep for tomorrow's show and tell with Building Module group, could you update deployed app with this latest merge? FYI the personal computer I used to test the container just died so I'm temporarily unable to test-run docker images locally.

matprov commented 2 years ago

Hi @JeremyFyke, it's updated. Let me know if you need to update something before tomorrow's presentation and i'll update it as well.

JeremyFyke commented 2 years ago

Amazing, OK, thanks. Would it also be easy to remove the placeholder 'choose a decision support tool' selector you originally made? I suspect this type of selector option may be best in the long term (re: your 'separate URL' question) - but while the option exists to select sectors inside the app itself, we may as well remove this placeholder for now.

I may try to add a few images in, in which case, there may be one more request for you to update before tomorrow's meeting. But if you don't hear from me, then it's all good. I just did a test run on https://climatedata.crim.ca/building-dst/ and it looks great.

matprov commented 2 years ago

Yes that's good, the selector would be removed as it is not necessary for now.