crim-ca / stac-populator

Workflow logic to populate STAC catalog with demo datasets.
MIT License
2 stars 2 forks source link

Security issues in requests calls #27

Open fmigneault opened 1 year ago

fmigneault commented 1 year ago

All requests calls should remove enforced verify=False. This is a debuging workaround that should not be enabled in deployed instances with valid SSL certificates.

The requests also assume open access. Realistically, most STAC API will not let user openly push new collections/items. The auth parameter must be supported to pass down an authentication/authorization method, such as https://github.com/Ouranosinc/requests-magpie

For convenience, CLI flags or utilities to pass extra arguments to requests calls could be added, but the should not enforce defaults that disable security features.