crim-ca / weaver

Weaver: Workflow Execution Management Service (EMS); Application, Deployment and Execution Service (ADES); OGC API - Processes; WPS; CWL Application Package
https://pavics-weaver.readthedocs.io
Apache License 2.0
24 stars 6 forks source link

use weaver-specific CWL extensions activation for schema validation #510

Closed fmigneault closed 1 year ago

fmigneault commented 1 year ago

Depends on #506 Diff:

Changes:

codecov[bot] commented 1 year ago

Codecov Report

Merging #510 (4b3de3f) into master (4242c94) will increase coverage by 0.07%. The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
+ Coverage   84.16%   84.23%   +0.07%     
==========================================
  Files          78       78              
  Lines       16700    16812     +112     
  Branches     2551     2558       +7     
==========================================
+ Hits        14055    14162     +107     
- Misses       1947     1952       +5     
  Partials      698      698              
Impacted Files Coverage Δ
weaver/utils.py 83.87% <61.53%> (-0.23%) :arrow_down:
weaver/processes/constants.py 100.00% <100.00%> (ø)
weaver/processes/wps_package.py 83.19% <100.00%> (+0.60%) :arrow_up:
weaver/wps_restapi/swagger_definitions.py 99.92% <100.00%> (+<0.01%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fmigneault commented 1 year ago

@ChaamC Using the CWL extensions loaded with this PR's changes, you should be able to provide cwltool:CUDARequirement directly in the requirements (if CUDA is indeed required for your app). If it can run in CPU-only mode, only then it should be set in hints, allowing the tool to ignore unfulfilled requirement by some machine/server running the app.