Closed fmigneault closed 1 year ago
Merging #558 (abe66fe) into master (dd99a64) will increase coverage by
0.02%
. The diff coverage is92.10%
.
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
+ Coverage 84.43% 84.45% +0.02%
==========================================
Files 79 79
Lines 17641 17702 +61
Branches 2675 2685 +10
==========================================
+ Hits 14895 14951 +56
- Misses 2019 2022 +3
- Partials 727 729 +2
Files Changed | Coverage Δ | |
---|---|---|
weaver/processes/convert.py | 84.18% <86.15%> (+0.10%) |
:arrow_up: |
weaver/database/base.py | 85.71% <100.00%> (ø) |
|
weaver/processes/constants.py | 100.00% <100.00%> (ø) |
|
weaver/processes/wps_package.py | 84.05% <100.00%> (ø) |
|
weaver/processes/wps_testing.py | 88.00% <100.00%> (ø) |
|
weaver/store/base.py | 100.00% <100.00%> (ø) |
|
weaver/wps_restapi/swagger_definitions.py | 99.82% <100.00%> (ø) |
Fixes
OpenAPI
schema link references toOGC API - Processes
repository.WPS
I/Ointeger
literal data conversion toOpenAPI
I/Oschema
definition injecting an invalidformat: double
property due to type checking withfloat
succeeding againstint
values.CWL
I/O value validation forenum
-like definitions from correspondingOpenAPI
andWPS
I/O. SinceCWL
I/O do not allowEnum
type for values other than basicstring
type,valueFrom
attribute is used to handleint
,float
andbool
types, using an embedded JavaScript validation against allowed values. Because of this validation strategy,CWL
packages must now includeInlineJavascriptRequirement
when allowed values for these basic types must be performed in order for theCWL
engine to parse I/O contents ofvalueFrom
(relates to https://github.com/common-workflow-language/cwl-v1.2/issues/267, https://github.com/common-workflow-language/common-workflow-language/issues/764 and https://github.com/common-workflow-language/common-workflow-language/issues/907).Literal
references for proper resolution involving values stored in constants.To Do
InlineJavascriptRequirement
automatically if missing whenvalueFrom
is added for input validation of numericsvalueFrom
validation