crimera / piko

revanced-patches for twitter
GNU General Public License v3.0
967 stars 31 forks source link

Bug `Download patch` acts weirdly #15

Closed What-Zit-Tooya closed 8 months ago

What-Zit-Tooya commented 8 months ago

Compared to revanced patches https://github.com/ReVanced/revanced-patches/commit/2c20844eaae698f185a9d321e2c70bde4b485cee and this https://github.com/ReVanced/revanced-patches/commit/d0f91c8550592723e1252e1af2971b508591dd59 , download video feature patch is weirdly. In same post, i can't download the video with crimera patch, but while using revanced patches i can download the video.

I am using the revanced CLI and this command:

java -jar revanced-cli-4.4.0-all.jar patch -p -o X_10.30.0-release.0-all-archs-crimera.apk --options options.json -b revanced-patches-1.9.0-dev.1.jar --alias=[snip] --keystore-password=[snip] --keystore-entry-password=[snip] --keystore=[snip].keystore -m revanced-integrations-1.2.0.apk com.twitter.android-10.30.0-release.0-all-archs.apk -i "Hide For You" -i "Google Ads Patch" -i "Hide Banner" -i "Hide Live Threads"

Example post link: https://twitter.com/le_sserafim/status/1763784207703441728

Screenshot from crimera X: Screenshot_20240302-135743

Screenshot from Revanced X: Screenshot_SS

I dont know if this bug already reported, but thats happened on my device.

crimera commented 8 months ago

Revanced patch targets the download sheet from the video player while the piko patch only targets the sheet from when you hold the video on the actual post. Will check back on this later.

A workaround for this is to include the official revanced patch bundle when building.

crimera commented 8 months ago

It seems revanced official patch bundle now gets all the videos as of release v4.3.0 will be disabling my own download patch in favor of theirs.