search

crimera / piko

revanced-patches for twitter
GNU General Public License v3.0
966 stars 31 forks source link

bug(Open browser chooser on opening links): Setting description is misleading #422

Open kitadai31 opened 1 month ago

kitadai31 commented 1 month ago

https://github.com/crimera/piko/blob/82e912a25687c891ae61c97a0d414168718b6fc8/src/main/resources/twitter/settings/values/strings.xml#L62

This description says "instead of using the in-app browser", but disabling the in-app browser can be achieved with an official Twitter setting. Due to this description, some users seem to misunderstand that this settings is for disabling the in-app browser.

I suggest this description.

-    <string name="piko_pref_browser_chooser_desc">Open links with browser chooser instead of using the in-app browser</string>
+    <string name="piko_pref_browser_chooser_desc">Open links with browser chooser instead of one of the installed browsers</string>

This suggestion is partially taken from the patch description, which describes more correctly the how the patch works:

https://github.com/crimera/piko/blob/82e912a25687c891ae61c97a0d414168718b6fc8/src/main/kotlin/crimera/patches/twitter/link/browserchooser/BrowserChooserPatch.kt#L12-L17

dic1911 commented 3 weeks ago

The patch was ported by me, ~I noticed that it doesn't work the same way it did on latest version~ (the description is actually correct, and the current behavior is wrong).

Update: The actual problem is that the patch signature is now outdated, there's no actual call to openWithChooser in decompiled smali from patched APK