crimera / piko

revanced-patches for twitter
GNU General Public License v3.0
967 stars 31 forks source link

10.62.0 and 10.62.1 cant be patched #428

Closed isillo closed 3 weeks ago

isillo commented 1 month ago

Guys? Its been already two days since 10.62.0 released and it cannot be patched, gives failure. 10.62.1 also. Usually crimera response was incredibly fast, we were having updated patches in manner of hours and now its been already two days and no new patches that could work with 10.62.x? Something bad happened? Im worried.

EDIT: typos

5uck3rpunch commented 1 month ago

I'm having the same issue on a Samsung Galaxy Z Fold 6 on one UI 6.1.1 (Android 14). I first contacted the ReVanced Manager dev, but we discovered this is only an issue when using Crimera/Piko.

I downloaded the X (previously Twitter) 10.62.1-release.0 .apkm from apkmirror.com. I then merge the split .apkm with AntiSplit M. I open ReVanced Manager & choose the antisplit .apk from local storage & use the default patches from the alternative source Crimera to get the Piko patch features. The pacthing runs & pauses for about 9 full seconds on Compiled classes4.dex & then also Compiled classes8.dex. The patching completes fast after that kicking up the full error. I have cleared all temp & log files. I have also cleared all storage in the Android Settings for this app. I have also uninstalled & reinstalled ReVanced Manager. ReVanced Manager has full permissions in Android Settings for the app.

revanced-manager_logcat_20241011063022079856.log

Screenshot_20241011_064627_ReVanced Manager

isillo commented 1 month ago

its almost 5 days now and no new version of a patches... gulp...are we doomed?

andreqsilva78 commented 1 month ago

I know the issue here is applying the crimera / piko patches via Revanced Manager. Anyway, while updated patches are not released, one option is to download the apk with the crimera/piko features from the link:

https://github.com/crimera/twitter-apk/releases/tag/10.62.1-release.0

crimera commented 1 month ago

Seems to be a manager issue, twitter patches successfully when using the revanced cli tool. The google photos patch also seems to be having the same issues. https://github.com/ReVanced/revanced-manager/issues/2142#issuecomment-2293169291. Best band-aid solution right now is by using revancify via termux

isillo commented 1 month ago

Can we reopen until its sorted?

5uck3rpunch commented 1 month ago

Can we reopen until its sorted?

Or at least you work with the ReVanced Manager team to let them know it's not a piko issue. They pushed me here saying it was your issue

isillo commented 1 month ago

Provided logs to Revanced Manager team, now they suggesting that problem is in one/some of the crimera/piko patches and expecting to narrow which one is it breaking and failing building. Feeling like being ping pong ball here :)

isillo commented 1 month ago

Hello again. Revanced developer investigation ended with conclusion: "Then, evidently, it's one of the patches on their end, for example, the one you picked but didn't tell the name of. Reopen with more information." Ticket available to read HERE: https://github.com/ReVanced/revanced-manager/issues/2262

isillo commented 1 month ago

hi crimera, please see discovery from revanced manager github: It failed while patching by cli even with a single patch(can be any). Just an assumption as every patch depends on settings patch maybe settings patch has some issues. log: INFO: Setting patch options INFO: Merging integrations INFO: Deleting existing temporary files directory INFO: Decoding resources INFO: Executing patches INFO: Remove Ads succeeded INFO: Compiling patched dex files INFO: Compiled classes.dex INFO: Compiled classes2.dex INFO: Compiled classes3.dex INFO: Compiled classes4.dex INFO: Compiled classes5.dex INFO: Compiled classes6.dex INFO: Compiled classes7.dex INFO: Compiled classes8.dex INFO: Compiled classes9.dex INFO: Compiled classes10.dex INFO: Compiled classes11.dex INFO: Compiled classes12.dex INFO: Compiling modified resources WARNING: /data/data/com.termux/files/usr/tmp/brut_util_Jar_10036788412223908336872107755013460287.tmp: 4: Syntax error: Unterminated quoted string brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 2): [/data/data/com.termux/files/usr/tmp/brut_util_Jar_10036788412223908336872107755013460287.tmp, compile, --dir, /storage/emulated/0/Download/1DMP/com.twitter.android_10.62.0-apkmirror.com_merged-patched-temporary-files/patcher/apk/res, --legacy, -o, /storage/emulated/0/Download/1DMP/com.twitter.android_10.62.0-apkmirror.com_merged-patched-temporary-files/patcher/apk/build/resources.zip] at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:123) at brut.androlib.AaptInvoker.invokeAapt(AaptInvoker.java:394) at app.revanced.patcher.data.ResourceContext.get(ResourceContext.kt:134) at app.revanced.patcher.Patcher.get(Patcher.kt:268) at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:312) at picocli.CommandLine.executeUserObject(CommandLine.java:2026) at picocli.CommandLine.access$1500(CommandLine.java:148) at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461) at picocli.CommandLine$RunLast.handle(CommandLine.java:2453) at picocli.CommandLine$RunLast.handle(CommandLine.java:2415) at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273) at picocli.CommandLine$RunLast.execute(CommandLine.java:2417) at picocli.CommandLine.execute(CommandLine.java:2170) at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12) Caused by: brut.common.BrutException: could not exec (exit code = 2): [/data/data/com.termux/files/usr/tmp/brut_util_Jar_10036788412223908336872107755013460287.tmp, compile, --dir, /storage/emulated/0/Download/1DMP/com.twitter.android_10.62.0-apkmirror.com_merged-patched-temporary-files/patcher/apk/res, --legacy, -o, /storage/emulated/0/Download/1DMP/com.twitter.android_10.62.0-apkmirror.com_merged-patched-temporary-files/patcher/apk/build/resources.zip] at brut.util.OS.exec(OS.java:104) at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:119) ... 13 more

another comment by someone else is: Some patch modifies the resources and does not format the strings properly.

isillo commented 4 weeks ago

Hi. any progress on that?

crimera commented 4 weeks ago

I think i found the issue, it happens when modifying the strings.

Seems that the default value of conference_default_title which is 𝕏 Conference gets modified into: Image.

Currently working on a fix.

isillo commented 3 weeks ago

any ETA?

crimera commented 3 weeks ago

No eta. But you can test the fix in revanced-manager compose through this bundle https://github.com/crimera/piko-patches-test/raw/refs/heads/main/bundle.json.

crimera commented 3 weeks ago

Fixed with: c20e16f80499df75176e9080f156e529f4f7d326, 1763137126b9a95df51fe23ce816853ccf0a8f44