crimera
commented
2 days ago Will try working on it this coming weekend
Open monefiera opened 4 days ago
crimera
commented
2 days ago Will try working on it this coming weekend
MondayNitro
commented
1 day ago the proposed patch only changes the accent color. it would be better to also allow users to change the background color for dark and light themes. (similar to the Inotia theme patch.)
since a pitch-black background might not be appeal to all users when paired with brighter accent colors provided in above patch
i changed my twitter app color using above guide and changed dark color
needless to say it wont look good with pitch black 000000 background
please whenever you add this patch, also provide options to change background colors
First
Twitter for Web implements a color theme consisting of six colors, and iOS has a similar feature (unless Elon has removed it), but no such feature exists for Android, even with Twitter Blue (Premium).
Origin Twitter which I've already released with full color patch and I would like to port this patch to piko in the future.
However, the patch content is very complex and I cannot do the PR myself yet, so I will post it on issues.
Expected behavior
The 1st ideal would be to enter a color code somewhere in the piko-settings, and color would change. However, given the need to change smali≒class, which I will discuss later, even I can foresee that this would be difficult.
So the most practical idea to implement this patch is to have a color code option that the user can change at will, similar to the theme options in Revanced and RVX.
In this idea, by entering a color code in Revancify or similar, the patch can be customized with a degree of freedom far beyond that of the Dynamic Color Patch.
How to do
I have already described what exactly needs to be changed and how in my repository, so I will just summarize the main points here. This application is not designed to change the theme color in the first place, so there is a wide range of areas that need to be changed.
Some are defined directly in #ff1d9bf0 & others instead of @color/twitter_blue, so this needs to be replaced first. All xml list that needs to be replaced have added again in Origin repository.
In styles.xml, we define the color of popups that indicate color links and unread notifications. If this color remains blue, it is an important change because changing the others will remain unnatural.
Also, coreColorBadgeVerified should be fixed to blue in case the user sets the theme to gold or gray, which could curb unnecessary confusion (as it is, it will change to the same color as the theme)
By the way, the two dark theme links text (named "abstractColorLink") are defined with @color/twitter_blue, but only the light theme is #ff1b95e0. This surprised me too.
Most troublesome is that some colors are defined directly in smali files, not in color.xml or style.xml. A full implementation requires converting these from HEX values (entered in options) to smali values and replacing the two color codes hidden in many smali files. Reference : #43
This isn't directly related to the main point. Origin resolved issue #402. In res/values/styles.xml's Theme.LaunchScreen, we changed the windowSplashScreenBackground to @color/twitter_ blue should solve this.
Lastly
I know this isn't necessarily feature that many people want, given the complexity of the patch. However, my Origin has been well received for a long time※ (at least more than I thought) and I'm sure there are certainly people who would appreciate it.
I will do my best to do what I can, and I hope you will move to implement it. ※Before moving to GitHub, Origin was published via mega.nz in my note(blog service for Japanese speakers) article.