Strip HTML tags from title tag

crimethinc / website

Ruby on Rails app that powers crimethinc.com

https://crimethinc.com

Creative Commons Zero v1.0 Universal

103 stars 31 forks source link

Strip HTML tags from title tag #1170

Closed veganstraightedge closed 5 years ago

veganstraightedge commented 5 years ago

https://crimethinc.com/2019/06/11/weve-reprinted-work-and-expect-resistance

https://api.rubyonrails.org/classes/ActionView/Helpers/SanitizeHelper.html#method-i-strip_tags

Jngai commented 5 years ago

I will take care of this.

Jngai commented 5 years ago

@veganstraightedge I got my environment set up and ran seed script. The seed script didn't go through completely but I got some articles seeded. I am at app/views/articles/show and the file is using <% cache. I can't see the changes. I tried to disable config.action_controller.perform_caching = false and clear caching with rake tmp:cache:clear etc but nothing changed. Can you help me out?

astronaut-wannabe commented 5 years ago

@Jngai thanks for picking this up!

The development cache should only be 1 second in development, so maybe something else is going on?

You can toggle the cache on/off by running:

bundle exec rails dev:cache

if that still doesn't work maybe try replacing all the contents of that file with

<h1>IS THIS THING ON??</h1>

to make sure it isn't something else besides the cache

veganstraightedge commented 5 years ago

@Jngai Thanks for taking on this issue!

@astronaut-wannabe suggestion is good. 👍🏻 If that also doesn't work, then you could comment out the cache/end lines while you do your development.

Let us know if there's anything else that we can do to help.

veganstraightedge commented 5 years ago

This same bug is also happening on suggested article cards in the footer of articles.

Maybe after you solve your issue's bug, we can abstract whatever solution you come up with into a generalized solution for all titles/subtitles.

veganstraightedge commented 5 years ago

Hi @Jngai. 👋🏻 Just checking in to see how it's going on this issue.

Any troubles that we can help you with?

Jngai commented 5 years ago

@veganstraightedge I went and contributed to another project instead...I remember I was stuck. If I have time I will come back to it and ask you for directions.

veganstraightedge commented 5 years ago

Ok. 👍🏻

Would you like to hold onto this issue or set it free for someone else to pick up? Either way is ok.

Jngai commented 5 years ago

set it free please

veganstraightedge commented 5 years ago

https://github.com/crimethinc/website/pull/1337