search

crimethinc / website

Ruby on Rails app that powers crimethinc.com
https://crimethinc.com
Creative Commons Zero v1.0 Universal
102 stars 31 forks source link

Create Redirects for images hosted in FTP #154

Open veganstraightedge opened 7 years ago

veganstraightedge commented 7 years ago
just1602 commented 2 years ago

Is it normal that when I try to access https://cdn.crimethinc.com/assets/everywhere/1a.jpg I get an access denied error?

veganstraightedge commented 2 years ago

Looking at the S3 bucket, that file path doesn't exist.

I think what I meant when I wrote this ticket was: that was just an example.

But I think the ideal version would be to find the actual places where each of those files actually are lives now, and redirect to correct image. Rather than just having a junk drawer of misc redirected images.

veganstraightedge commented 2 years ago

But maybe this whole ticket is a moot point because most everything will be in ActiveStorage soon, which doesn't have static URLs (AFAIK at least).

just1602 commented 2 years ago

The right way to do the redirection is probably to find all images in the public folder and in the content and redirect them to CDN.

Oh, you plan to migrate all image with static link to Active Storage? I'm wondering how we can handle redeployment or stuff like that since in local we have to reinsert every image from the bucket, tho?

veganstraightedge commented 2 years ago

I'm not sure how we should handle Active Storage + local development.

I don't think we should put all images the CDN or Active Storage. Like the logo and stuff, that should probably stay in app/assets/images. But the stuff in public/ that was there for old features or TCE etc. Those should all move into: app/assets/images or the CDN.