Add titles to /languages/* pages - Githubissues

crimethinc / website

Ruby on Rails app that powers crimethinc.com

https://crimethinc.com

Creative Commons Zero v1.0 Universal

101 stars 31 forks source link

Add titles to /languages/* pages #1568

Closed veganstraightedge closed 4 years ago

veganstraightedge commented 4 years ago

https://crimethinc.com/languages/bengali

It should have a title tag value like: বাংলা / Bengali (baanlaa)

just1602 commented 4 years ago

Is there something else than the actual title going here?

veganstraightedge commented 4 years ago

Nope! It just needs a decent title. Right now, it's empty / the default site title.

just1602 commented 4 years ago

Ohhh you mean this title ! Got it !

just1602 commented 4 years ago

@veganstraightedge call you tell me what would I need to do to make @title = PageTitle.new title_for(:languages) to render Crimethinc. : Languages instead of Crimethinc. : index as /languages title?

just1602 commented 4 years ago

If i use title_for("Languages") it works, but I want it to be translatable.. But i don't understand why it didn't work with the symbol since there is a languages key in the en locale file?

just1602 commented 4 years ago

Ok, got it ! :D