search

crimx / ext-saladict

🥗 All-in-one professional pop-up dictionary and page translator which supports multiple search modes, page translations, new word notebook and PDF selection searching.
https://saladict.crimx.com/
MIT License
11.98k stars 730 forks source link

Compatibility with chatGPTBox. #2049

Open KAGEYAM4 opened 1 year ago

KAGEYAM4 commented 1 year ago

Device info

Describe the bug

When i select/highlight some text two pop-ups appear, saladict and chatGPTBox. Now if select saladict, the chatgptbox dosen't disappear and follows the mouse.

To Reproduce

  1. Select some text
  2. Click on 'Saladict-pop-up'
  3. ChatGPTBox pop up dosen't goes away

Expected behavior

ChatGPTBox pop-up goes away.

Screenshots

image

Additional context

I created the same issue on chatGPTBox repo first. https://github.com/josStorer/chatGPTBox/issues/412 This was the solution suggested by them. https://github.com/josStorer/chatGPTBox/issues/412#issuecomment-1589183448

crimx commented 1 year ago

I would suggest enabling Saladict icon mode which should make sure the Saladict panel is on top.

KAGEYAM4 commented 1 year ago

I am have enable that but it dosen't work. If i chose to click saladict the chatgptbox dosen't go away.--

Screenshot ![image](https://github.com/crimx/ext-saladict/assets/75798544/264dbb06-9680-4e72-8beb-880c5a6b915d)
crimx commented 1 year ago

That's weird. Both extensions use same z-index. Icon mode will make sure the Saladict panel is rendered after the chatGPTBox.

image