search

cript0nauta / pynixify

Nix expression generator for Python projects
GNU General Public License v3.0
64 stars 11 forks source link

support some pep517 build backends #64

Closed emmettbutler closed 1 year ago

emmettbutler commented 1 year ago
cript0nauta commented 1 year ago

Pins nixpkgs to improve reproducibility

I think this change shouldn't be necessary. If you use the --nixpkgs option, the expression will be instantiated with <nixpkgs> pinned to the desired version: https://github.com/cript0nauta/pynixify/blob/main/pynixify/nixpkgs_sources.py#L135

cript0nauta commented 1 year ago

Adds a --py argument to the CLI allowing the user to specify the Python version to be used in the built shell

This change looks good. Would you be able to create a new PR that only includes this fix, without any changes to formatting or import order?

Also, please make sure to use the escape_string function when including a string inside a Nix expression.

cript0nauta commented 1 year ago

Fixes an infinite recursion bug by avoiding package name collisions in overlay

Do you have an example of when this bug is triggered? Maybe we should create a test in the command test suite that reproduces it.

cript0nauta commented 1 year ago

Adds support for the hatchling and flit_core PEP517 build backends

This changeset looks interesting, though I'm not familiar with PEP517. I'll need some time to review the changes since they're larger than the other fixes.

Thanks again for your contributions!

emmettbutler commented 1 year ago

@cript0nauta thanks for the quick feedback! i broke out the pep517 changes into this pull request for your review https://github.com/cript0nauta/pynixify/pull/65

here's a pull request implementing the new cli option https://github.com/cript0nauta/pynixify/pull/66

here's a pull request showing how to replicate the recursion bug i encountered https://github.com/emmettbutler/pynixify/pull/4

thanks again! i'll look forward to your feedback.