crisbeto / angular-svg-round-progressbar

Angular module that uses SVG to create a circular progressbar
https://crisbeto.github.io/angular-svg-round-progressbar/
MIT License
742 stars 173 forks source link

RoundProgressModule is not an NgModule #112

Closed NickMcBurney closed 2 years ago

NickMcBurney commented 7 years ago

Hi,

Im trying to use this within an angular-cli project, I have installed via npm and imported into my app:

import { RoundProgressModule } from 'angular-svg-round-progressbar';
@NgModule({
  declarations: [
    AppComponent,
  ],
  imports: [
    BrowserModule,
    FormsModule,
    ReactiveFormsModule,
    HttpModule,
    routing,

    DashboardModule,
    RoundProgressModule
  ],
  providers: [],
  bootstrap: [AppComponent]
})

export class AppModule { }

but when I try and either build or serve the app using ng serve I get an error:

ERROR in RoundProgressModule is not an NgModule

NitheshHeshitha commented 7 years ago

I am getting cant import "undefined" from appmodule

crisbeto commented 7 years ago

What version are you guys using?

NitheshHeshitha commented 7 years ago

I am using "1.0.5" version

crisbeto commented 7 years ago

Alright, then it's related to the issues that people are reporting at https://github.com/crisbeto/angular-svg-round-progressbar/issues/65. I need to switch to using ngc.

NitheshHeshitha commented 7 years ago

So when can we except ?

crisbeto commented 7 years ago

I'm not trying to give any guarantees since I'm pretty busy. I'll try to carve out some time this week.

NickMcBurney commented 7 years ago

Im also on V1.0.5, thanks @crisbeto

CarlosTorrecillas commented 7 years ago

thanks for this @crisbeto . Much appreciated if you could make the change this week 👍

crisbeto commented 7 years ago

I've been trying some stuff out. It would be really helpful if you guys could try this out and let me know if it fixes it for you: https://github.com/crisbeto/angular-svg-round-progressbar/issues/65#issuecomment-286441243

CarlosTorrecillas commented 7 years ago

Should we expect to have a umd.js on that zip?

crisbeto commented 7 years ago

No, it only points the main to index.js which exposes the module.

CarlosTorrecillas commented 7 years ago

That's what I thought. I am now referencing the index.js on the systemjs.config.js and it's not able to load the app:

Error: Fetch error: 404 Not Found Instantiating http://localhost:10100/node_modules/angular-svg-round-progressbar/dist/round-progress.component

LucasKubicki commented 7 years ago

error I have that error if its can help

And in local this one : ERROR in RoundProgressModule is not an NgModule

EmanuelCarneiro commented 7 years ago

hi guys,

I fixed this by copying the files in the source code (in the repo) and importing the Module from the local files rather than the node_modules.

Is not ideal but it solves the problem for now.

acassan commented 7 years ago

Hello,

Have you plan to commit fix on master ? :-)

Thanks

crisbeto commented 7 years ago

I've released 1.0.6 which includes the new build output. Also here's Angular's "getting started" app which has imported the round progress module. toh-3.zip

vandres commented 7 years ago

1.0.6 works for me with Ionic 2 in production mode

crisbeto commented 7 years ago

@NickMcBurney can you confirm whether it works with 1.0.7?

katestearns-suplari commented 7 years ago

I'm getting the same issue - I tried the npm install that was recommended in the comment with no luck. Any updates on what we need to do?

crisbeto commented 7 years ago

I was under the impression that it works as expected now. Can you post an example @katestearns-suplari?

katestearns-suplari commented 7 years ago

I uninstalled and reinstalled and it is now working