Feature/add ng content placeholder and fill color

crisbeto / angular-svg-round-progressbar

Angular module that uses SVG to create a circular progressbar

https://crisbeto.github.io/angular-svg-round-progressbar/

MIT License

742 stars 173 forks source link

Feature/add ng content placeholder and fill color #114

Closed CiprianMate closed 7 years ago

CiprianMate commented 7 years ago

Hey, crisbeto! Thank you for your quick response. You are right about the fill. However, I think that view encapsulation should be kept and include the ng-content instead, because the same can be achieved with ng-content as with a background image and also maintain the view encapsulation. Please let me know in case I'm missing something, otherwise I'm looking forward to your thoughts on this.

What I'm looking to achieve is captured in the PS below:

crisbeto commented 7 years ago

I don't think the view encapsulation is too important. There are 3 CSS rules which should be pretty easy to scope to the component.