crisbeto / angular-svg-round-progressbar

Angular module that uses SVG to create a circular progressbar
https://crisbeto.github.io/angular-svg-round-progressbar/
MIT License
741 stars 173 forks source link

Angular 5.0.0 looks to be not supported #142

Closed CarlosTorrecillas closed 6 years ago

CarlosTorrecillas commented 6 years ago

After upgrading to Angular 5.0.0 I got the following error:

Uncaught Error: Unexpected value 'RoundProgressModule' imported by the module 'AppModule'. Please add a @NgModule annotation.

It would be nice if the relevant changes could be made to make it compatible.

Thanks!

crisbeto commented 6 years ago

It seems to work fine with Angular 5, you may be getting the error because the published metadata is for Angular 4. I'll do a release that bumps the version.

crisbeto commented 6 years ago

I've released 1.2.0 that bumps the required version to 5.0.

CarlosTorrecillas commented 6 years ago

Weird, I just updated and I think get the same:

compiler.js:15827 Uncaught Error: Unexpected value 'RoundProgressModule' imported by the module 'AppModule'. Please add a @NgModule annotation.
    at syntaxError (compiler.js:466)
    at eval (compiler.js:15088)
    at Array.forEach (<anonymous>)
    at CompileMetadataResolver.getNgModuleMetadata (compiler.js:15071)
    at JitCompiler._loadModules (compiler.js:33484)
    at JitCompiler._compileModuleAndComponents (compiler.js:33445)
    at JitCompiler.compileModuleAsync (compiler.js:33361)
    at CompilerImpl.compileModuleAsync (platform-browser-dynamic.js:230)
    at PlatformRef.bootstrapModule (core.js:5443)
    at eval (webpack-internal:///../../../../../src/main.ts:13)

My packages.json:

 "dependencies": {
    "@angular/animations": "5.0.0",
    "@angular/common": "5.0.0",
    "@angular/compiler": "5.0.0",
    "@angular/core": "5.0.0",
    "@angular/forms": "5.0.0",
    "@angular/http": "5.0.0",
    "@angular/platform-browser": "5.0.0",
    "@angular/platform-browser-dynamic": "5.0.0",
    "@angular/platform-server": "5.0.0",
    "@angular/router": "5.0.0",
    "@ng-bootstrap/ng-bootstrap": "1.0.0-beta.5",
    "@nguniversal/express-engine": "1.0.0-beta.3",
    "@nguniversal/module-map-ngfactory-loader": "1.0.0-beta.3",
    "angular-svg-round-progressbar": "1.2.0",
    "angular2-cookie": "1.2.6",
    "bootstrap": "4.0.0-beta.2",
    "core-js": "2.5.1",
    "font-awesome": "4.7.0",
    "rxjs": "5.5.2",
    "web-animations-js": "2.3.1",
    "zone.js": "0.8.18"
  },
papaiatis commented 6 years ago

I have the same problem here!

Skyless7 commented 6 years ago

On 1.2.0 version only the warning in terminal after ng serve dissapears.

On running application same error occours "ERROR Error: Uncaught (in promise): Error: Unexpected value 'RoundProgressModule' imported by the module 'Something'. Please add a @NgModule annotation."

YamanSehzade commented 6 years ago

hi @crisbeto, do you have any solution ? I have a same problem. Could you help us, please ?

AndreasWJ commented 6 years ago

Same problem here...