search

crisbeto / angular-svg-round-progressbar

Angular module that uses SVG to create a circular progressbar
https://crisbeto.github.io/angular-svg-round-progressbar/
MIT License
741 stars 173 forks source link

Should the dependencies be peer dependencies? #163

Closed oleersoy closed 6 years ago

oleersoy commented 6 years ago

Should the dependencies be peer dependencies? It seems like these should be provided by the runtime environonment:

  "dependencies": {
    "@angular/compiler": "^5.0.0",
    "@angular/common": "^5.0.0",
    "@angular/core": "^5.0.0",
    "core-js": "^2.4.1",
    "rxjs": "^5.5.0",
    "zone.js": "^0.8.12"
  },
MichielDean commented 6 years ago

This seems to be the cause of our broken build with yarn. Is this package still active? I haven't seen a response to any of these issues.

crisbeto commented 6 years ago

It’s still active, I’ve just been busy with other projects and there isn’t that much to do on this one. I’ll switch them to peer dependencies when updating it to Angular 6.

MichielDean commented 6 years ago

I don't mind submitting a PR for changing those to peer dependencies, if you would prefer that.

crisbeto commented 6 years ago

I've also got some other things that need cleaning up that I'm planning on doing altogether.

crisbeto commented 6 years ago

By the looks of it I won't have time for that build cleanup, but I've released 2.0.0 which updates to Angular 6 and switches the dependencies to peerDependencies.