search

crisbeto / angular-svg-round-progressbar

Angular module that uses SVG to create a circular progressbar
https://crisbeto.github.io/angular-svg-round-progressbar/
MIT License
741 stars 173 forks source link

Question: Does v4 break on Angular 9? #206

Closed wcjord closed 3 years ago

wcjord commented 3 years ago

I know the peer dependency is for Angular 10 but does it break on Angular 9? Is there a version of the progressbar that would work for 9?

crisbeto commented 3 years ago

It just bumps the peer dependency, but it should work on pretty much any version of Angular after 2.

wcjord commented 3 years ago

Awesome! Thank you.

On Aug 28, 2020, at 11:51 AM, Kristiyan Kostadinov notifications@github.com wrote:

It just bumps the peer dependency, but it should work on pretty much any version of Angular after 2.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/crisbeto/angular-svg-round-progressbar/issues/206#issuecomment-682753726, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHYPKFIJ3SZTRTOTVVNHZ5DSC7G7JANCNFSM4QOIINAQ.

nelson6e65 commented 3 years ago

Could you add Angular => 9 instead of fixed to 10 peer dependency?

So, I'm getting a bunch of warnings:

npm WARN angular-svg-round-progressbar@4.0.0 requires a peer of @angular/core@^10.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular-svg-round-progressbar@4.0.0 requires a peer of @angular/common@^10.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular-svg-round-progressbar@4.0.0 requires a peer of core-js@^2.4.1 but none is installed. You must install peer dependencies yourself.

And idk if I can use version 5 neither:

npm WARN angular-svg-round-progressbar@5.0.2 requires a peer of @angular/core@^10.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular-svg-round-progressbar@5.0.2 requires a peer of @angular/common@^10.0.0 but none is installed. You must install peer dependencies yourself.

I didn't find a breaking in change log or something. 😭

crisbeto commented 3 years ago

I expect that it'll work down to version 2.0 since it's only using some very basic framework features and the rest is DOM manipulation and math. I've been bumping up the version as people have requested it and as new version have been released.

nelson6e65 commented 3 years ago

Oh! Nice! Thanks.