crisbeto / angular-svg-round-progressbar

Angular module that uses SVG to create a circular progressbar
https://crisbeto.github.io/angular-svg-round-progressbar/
MIT License
741 stars 173 forks source link

Inconsistent URL Parsing in resolveColor function affecting SVG Strokes #235

Closed nileshbhagwat closed 8 months ago

nileshbhagwat commented 8 months ago

Description: There is an issue in the resolveColor function within round-progress.service.ts. When this function processes URLs with auxiliary routes for SVG strokes using [style.stroke]="resolveColor(...)", the URLs are not being interpreted correctly.

Expected Behavior: SVG strokes should be consistently displayed when their URLs contain auxiliary routes.

Actual Behavior: The SVG stroke fails to render when the resolveColor function processes and returns a URL with auxiliary routes.

Suggested Fix: We should update the resolveColor function to enclose URLs in double quotes.

For instance, alter the URL pattern

Reference: https://developer.mozilla.org/en-US/docs/Web/CSS/url

image

nileshbhagwat commented 8 months ago

Closing the issue, as it appears the app can accommodate URL specifications as needed.