search

crisbeto / angular-svg-round-progressbar

Angular module that uses SVG to create a circular progressbar
https://crisbeto.github.io/angular-svg-round-progressbar/
MIT License
742 stars 173 forks source link

Progress is not centred exactly and in safari its way off #40

Closed santbob closed 9 years ago

santbob commented 9 years ago

thanks for this wonderful module, but it not exactly centred vertically. in safari it completely off.

Visiting https://crisbeto.github.io/angular-svg-round-progressbar/ in safari shows it.

In Chrome and Firefox, i see that the styles get assigned are 

    top: 50%;
    bottom: 50%;
    left: 50%;
    transform: translateY(-50%) translateX(-50%);
    font-size: 21px;

setting both top and bottom to 50% leaves the text to be of zero height, may be the css needs to be reconsidered

crisbeto commented 9 years ago

Hey, thanks for reporting this. It was actually a case of me forgetting the vendor prefixes on the transform on the demo page. Its fixed now.

santbob commented 9 years ago

@crisbeto thanks for fixing it super fast, can you push a bower version as well.

crisbeto commented 9 years ago

This is a change only in the demo, I don't think it needs a release.