Closed jasonconway-williams closed 8 years ago
crisbeto, I have removed the text in the footer declaration and have added an index.js file instead. This follows the usual standard of implementing both a modular and non-modular artefact.
Non npm/commonjs users will be able to add a reference to the roundProgress.js script in their HTML, users who want to take the modular approach will be able to require the npm module name in their js scripts. This approach will prevent any errors occurring in the browser.
In that case, couldn't you just add a index.js
? No need to generate it via Grunt.
crisbeto could do but how likely is it that the build directory will be deleted since it is used to store generated files?
The build directory doesn't get cleared on builds. You can see that the index.html
for the demo is there as well.
crisbeto, I will remove the grunt file create task and leave the index.js file in the build directory.
All done crisbeto, good catch.
Thank you, I'll release this right away.
crisbeto, are you also going to perform an npm update to publish these changes to npm so we only have to reference the package name in the package.json file rather than the github url?
Yes, it's already updated on NPM.
Note that just adding
module.exports = 'angular-svg-round-progressbar';
will throw an error in non-CommonJS environments. You should wrap it like this: