Closed criscmaia closed 6 years ago
Similar issue, it lets you submit a valid option more than once
In case of D1 it will filter out anything that is not value between A and E or 0.
I am using regex to filter out all the values.
In case of AAAA it will only look for value of A in the answer once, so you can enter 100 times A and it will still count as A once :)
Excellent. Let's just have it output as incorrect answer and ask the user to try again instead of filtering the correct one.
On 5 Nov 2017 23:11, "Matthew" notifications@github.com wrote:
In case of D1 it will filter out anything that is not value between A and E or 0.
I am using regex to filter out all the values.
In case of AAAA it will only look for value of A in the answer once, so you can enter 100 times A and it will still count as A once :)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/criscmaia/gsdslack/issues/30#issuecomment-342013934, or mute the thread https://github.com/notifications/unsubscribe-auth/AIpvJil1KiVcB_Vd_pmHTgPMPJu3U-lZks5szkC5gaJpZM4QSfAt .
nope, if they want to update their question they have a 0 option to do that. I made the bot smart enough to be able to handle this sort of problems.
updated a response
Update, the bot will shout at you whenever you type an incorrect value.
Error message is: Incorrect value please select ABCD values, or type 0 to return to previous question.
Should mention E option as well, but not sure how. Will get George to come up with the best sentence.
Still doing the main test
Correct: A0 or 0A doesn't work. Good!
Incorrect: AAA still works. It shouldn't. Can't assume that they meant to type only one A. ABE works. It shouldn't. You either select between A to D or E for none.
(aa+|bb+|cc+|dd+|ee+|a+0|b+0|c+0|d+0|a+e|b+e|c+e|d+e|e+a|e+b|e+c|e+d) Hopefully this will make the bot even more anoying....
(aa+|bb+|cc+|dd+|ee+|a+0|b+0|c+0|d+0|a+e|b+e|c+e|d+e|e+a|e+b|e+c|e+d)|[^a-e -]|(0-9) This will make it even more anoying
Please test and let me know if it is all fine.
Testing everything Timezone set up - good survey dummy - good MBTI - good PAEI - almost good: the RESULTS brackets are messed up: P(15), A(16, E(15), I(9)) VARK - wrong: 1) my VARK table is not clear (this means that if a student does up to question 10, stops, start again (for whatever reason we allow) and do up to 5, it will have the last 5 from the 1st attempt meaning two attempts together) 2) inputs issues: ABA works (bad) BAB works (bad) 0A0 doesn't work (good) BAA doesn't work (good) ACC doesn't work (good) 0 deletes row from surveyVarkChosenOptions (great) 3) add results description (Cristiano to provide details)
my VARK table is not clear (this means that if a student does up to question 10, stops, start again (for whatever reason we allow) and do up to 5, it will have the last 5 from the 1st attempt meaning two attempts together)
No clue what you are talking about....
2) inputs issues: ABA works (bad) BAB works (bad)
Done please check
All working! \o/