Closed aPruner closed 4 years ago
Will update this PR with screenshots of the new UX elements/workflows
@PimDeWitte new solution (as agreed upon in slack) for the default map centering is to just add 2 new env vars to config/credentials called MAP_CENTER_DEFAULT_LATITUDE
and MAP_CENTER_DEFAULT_LONGITUDE
NOTE: This PR is a WIP (Work in Progress) - DO NOT MERGE YET!
DONE:
config/credentials.js
to the.gitignore
, added a blueprint calledconfig/credentials-outline.js
so that users can create their own local version ofconfig/credentials.js
to throw API keys and such into that don't get committed - docs on this to come (.env might be a better solution, but this was necessary for me to get the MAP_KEY variable working)react-geocode
andnavigator.geolocation
geolocation-API related code into a re-usableUtils/geolocation.js
file. We should expand thisUtils
library to include any utility-related functions that shouldn't exist inside component files. Examples of this might be regex validation, sorting, string manipulation, math, etcDiscussionPin
s on the map are created for both pinned and unpinned discussions (this is the result of a design flaw, there shouldn't be separate arrays for these in the first place)Add a map toggle (maybe, might create separate issue for this)- (Create separate issue)Colour-fade for DiscussionPins(Create separate issue)Determine and implement mobile behaviour for the feature (Don't show the map)(Create separate issue)STILL TODO: