search

crisishistory / HistoryAIToolkit

AI toolkit for professional and amateur oral historians
GNU General Public License v3.0
11 stars 18 forks source link

Removed unrequired packages, and added which are required #52

Closed VivekKumarKamal closed 1 year ago

VivekKumarKamal commented 1 year ago

I have removed the unrequired packages and I have added the required ones.

image

Fixes #40

What I did

I checked the code, where are the packages being used. On my machine I ran the code and then installed the packages one by one to find the required packages, and then added/removed in the requirements.txt.

Thank You for this issue, this is the first time ever I created a PR.

audreyfeldroy commented 1 year ago

Perfect, thanks @VivekKumarKamal. Merged 🚢

VivekKumarKamal commented 1 year ago

Thank You so much @audreyfeldroy. How can I update pyproject.toml, will you put a issue, or there is any other way?

audreyfeldroy commented 1 year ago

Great question. For requests like this, typically you just send a separate PR and there might not necessarily be a new issue. But I'll create an issue to guide you with some specifics 🙂

VivekKumarKamal commented 1 year ago

Okay, Thank you 😀