Simplify slicer.py by using Python ffmpeg bindings

crisishistory / HistoryAIToolkit

AI toolkit for professional and amateur oral historians

GNU General Public License v3.0

11 stars 18 forks source link

Simplify slicer.py by using Python ffmpeg bindings #68

Open audreyfeldroy opened 12 months ago

audreyfeldroy commented 12 months ago

[ ] Look into if https://github.com/kkroening/ffmpeg-python has Python code similar to slicer.py
[ ] Check if there are other similar Python ffmpeg bindings
[ ] If so, refactor slicer.py to reduce our lines of code by using any Python ffmpeg bindings as a dependency

heymanpreet commented 12 months ago

@audreyfeldroy I can have a look at it if not started by anyone? Thanks.

audreyfeldroy commented 12 months ago

Great, I assigned this to you, thanks!

audreyfeldroy commented 12 months ago

@heymanpreet I realize there may be some overlap and large merge conflicts with what @RalphHuber started on yesterday with #62. Please wait until he is finished with his pull request. Or pair program together on determining what would be best for the slicer code 🙂

heymanpreet commented 12 months ago

@audreyfeldroy No worries, I will wait until @RalphHuber is done. Thanks for letting me know.🙂

RalphHuber commented 12 months ago

Cheers @heymanpreet , sorry, will have a PR up for it today, have hopefully separated things out a little bit so it'll be easier to replace pydub if necessary

heymanpreet commented 12 months ago

Thanks, No rush @RalphHuber, let me know when its done. 🙂

audreyfeldroy commented 12 months ago

We're done with our exploration of #72 and you have the go ahead to start exploring here @heymanpreet if you'd like 😊

heymanpreet commented 12 months ago

Cool, Thanks for the update @audreyfeldroy, I will resume work on the issue. :)