search

criso / fbgraph

NodeJs module to access the facebook graph api
http://criso.github.io/fbgraph/
1.09k stars 177 forks source link

Is this still maintained? #135

Closed guyisra closed 6 years ago

guyisra commented 6 years ago

Is this package still maintained? Does it need more maintainers to help out?

ffflabs commented 6 years ago

ping @criso I use this library thoroughly, and I'll be happy to contribute.

wilforlan commented 6 years ago

@amenadiel some of the apis are depreciated

BrandonCookeDev commented 6 years ago

I don't think it is. There's a PR (#130) out there that fixes the deprecated API issue but it's been ignored for months.

criso commented 6 years ago

Yeah - haven't had time to do any work on this. I've merged some of the less impactful PRs. I'll rev up a version on npm and do have plans of updating this - but honestly forking the code and iterating on it will be quicker

guyisra commented 6 years ago

@amendiel do you still have time to work on this? Perhaps @criso can make you a maintainer?

ffflabs commented 6 years ago

I use this library on a daily basis and I've been struggling with the (exagerated) API changes after Cambridge Analytica so yeah, I can spend a couple at least an hour each day looking at PRs and my employer would consider it part of my duties.

@criso

ffflabs commented 6 years ago

BTW people, even if the default version still says 2.4, it's up to the user to pass a newer version when calling setVersion method. I'm using version 2.12 and all endpoints I use (pages and post insights, marketing insights, token information and extension, user info, user accounts, etc) do still work.

For sure, some of them could be wrapped into methods that would reduce the verbosity of the request, but template literals will take you a long way if you use them right.

criso commented 6 years ago

Awesome! Added @amenadiel as collaborator 🤘 Thanks @amenadiel ! :)

ffflabs commented 6 years ago

Whoa! I'll start digging into issues and PR tonight

@criso I guess publishing new hotfixes to npm will still be up to you. If you're comfortable with that, once in a while I'll message you when a release is due.