criso / fbgraph

NodeJs module to access the facebook graph api
http://criso.github.io/fbgraph/
1.09k stars 176 forks source link

added setVersion for setting graph api version #69

Closed chrisjhoughton closed 9 years ago

chrisjhoughton commented 9 years ago

Took me long enough! Apologies for the delay.

@xpepermint commented here regarding also adding the version to the OAuth dialog URLs, which would probably work, but it's not officially recommended or documented in Facebook's docs, so I didn't add it.

Didn't try getting the tests to work as you mentioned they were a little flaky.

xpepermint commented 9 years ago

@chrisjhoughton I use OAuth dialog (in my own script for now) with version because otherwise you don't get the new facebook view/options.

chrisjhoughton commented 9 years ago

You're absolutely right, I'll update accordingly. On 11 Oct 2014 08:39, "Kristijan Sedlak" notifications@github.com wrote:

@chrisjhoughton https://github.com/chrisjhoughton I use OAuth dialog (in my own script for now) with version because otherwise you don't get the new facebook view/options.

— Reply to this email directly or view it on GitHub https://github.com/criso/fbgraph/pull/69#issuecomment-58741426.

chrisjhoughton commented 9 years ago

Ok added the URLs, looks good.

xpepermint commented 9 years ago

awesome

criso commented 9 years ago

aww yeah