search

crisp-im / crisp-sdk-web

:package: Include the Crisp chat widget from using frameworks such as React, VueJS, Angular...
https://www.npmjs.com/package/crisp-sdk-web
MIT License
39 stars 13 forks source link

Passing options to configure() disables autoload #7

Closed jakajancar closed 1 year ago

jakajancar commented 1 year ago

It is very misleading that passing options to configure() (e.g. locale, or even an empty {}) disables autoload. I suspect most people will assume that whatever option they passed is what broke the widget.

Instead of

configure(websiteId: string, options: Options = {autoload : true }) {

it should be

configure(websiteId: string, options: Options = {}) {

and then defaults should be resolved on a per-option basis within the body.

baptistejamin commented 1 year ago

Thank you for the report!

Issue got fixed