search

crisp-im / crisp-sdk-web

:package: Include the Crisp chat widget from using frameworks such as React, VueJS, Angular...
https://www.npmjs.com/package/crisp-sdk-web
MIT License
39 stars 13 forks source link

Fixing breaking change: Added build step to publish flow #9

Closed maxsynnott closed 1 year ago

maxsynnott commented 1 year ago

The current version doesn't allow imports like the following while it used to:

import { Crisp } from 'crisp-sdk-web'

This is because the package no longer includes a dist folder.

This is because your new build workflow wasn't actually running the build script before publishing. This change includes a step running the build script before publishing which should fix the issue.

Your documentation specifically shows importing like this, so this was likely a breaking change for many.

Merging this and deploying a new version would be appreciated as then my team can update to the latest version.

baptistejamin commented 1 year ago

Thank you so much for your help! Can you please send your email to baptiste@crisp.chat ?