search

crisp-im / node-crisp-api

:zap: Crisp API Node Wrapper
https://docs.crisp.chat/guides/rest-api/
MIT License
99 stars 39 forks source link

Generate TypeScript types from JSDoc #36

Closed P4sca1 closed 2 years ago

P4sca1 commented 2 years ago

Signed-off-by: Pascal Sthamer sthamer.pascal@gmail.com

valeriansaliou commented 2 years ago

Thank you! Looks good. Merging now, and releasing ASAP :)

P4sca1 commented 2 years ago

Thanks for the fast release! :) I just tried version 4.1.0 and noticed there is a small issue, which prevents the types from being picked up correctly in a TypeScript project. I created another PR, which fixes this issue: https://github.com/crisp-im/node-crisp-api/pull/37

valeriansaliou commented 2 years ago

Merged manually, thanks :)