search

crisp-im / node-crisp-api

:zap: Crisp API Node Wrapper
https://docs.crisp.chat/guides/rest-api/
MIT License
99 stars 38 forks source link

8.0.1 : Cannot find name 'WebSockets'. Did you mean 'WebSocket'? #55

Closed QuentinFarizon closed 1 year ago

QuentinFarizon commented 1 year ago

Whne updating to 8.0.1 :

$ tsc --version && tsc --noEmit
Version 4.6.4
../../node_modules/crisp-api/types/crisp.d.ts:114:325 - error TS2552: Cannot find name 'WebSockets'. Did you mean 'WebSocket'?

114     export { RTM_MODES, AVAILABLE_RTM_MODES, DEFAULT_REQUEST_TIMEOUT, DEFAULT_SOCKET_TIMEOUT, DEFAULT_SOCKET_RECONNECT_DELAY, DEFAULT_SOCKET_RECONNECT_DELAY_MAX, DEFAULT_SOCKET_RECONNECT_FACTOR, DEFAULT_BROKER_SCHEDULE, DEFAULT_EVENT_REBIND_INTERVAL_MIN, DEFAULT_USERAGENT_PREFIX, DEFAULT_REST_HOST, DEFAULT_REST_BASE_PATH, WebSockets as DEFAULT_RTM_MODE, DEFAULT_RTM_EVENTS, Crisp };
                                                                                                                                                                                                                                                                                                                                        ~~~~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:16222:13
    16222 declare var WebSocket: {
                      ~~~~~~~~~
    'WebSocket' is declared here.
baptistejamin commented 1 year ago

Recommending to use SkipLibCheck in your Typescript config.

Baptiste Jamin

On 22 Aug 2023, at 16:30, Quentin Farizon @.***> wrote:

Whne updating to 8.0.1 :

$ tsc --version && tsc --noEmit Version 4.6.4 ../../node_modules/crisp-api/types/crisp.d.ts:114:325 - error TS2552: Cannot find name 'WebSockets'. Did you mean 'WebSocket'?

114 export { RTM_MODES, AVAILABLE_RTM_MODES, DEFAULT_REQUEST_TIMEOUT, DEFAULT_SOCKET_TIMEOUT, DEFAULT_SOCKET_RECONNECT_DELAY, DEFAULT_SOCKET_RECONNECT_DELAY_MAX, DEFAULT_SOCKET_RECONNECT_FACTOR, DEFAULT_BROKER_SCHEDULE, DEFAULT_EVENT_REBIND_INTERVAL_MIN, DEFAULT_USERAGENT_PREFIX, DEFAULT_REST_HOST, DEFAULT_REST_BASE_PATH, WebSockets as DEFAULT_RTM_MODE, DEFAULT_RTM_EVENTS, Crisp };


  node_modules/typescript/lib/lib.dom.d.ts:16222:13
    16222 declare var WebSocket: {
'WebSocket' is declared here.

— Reply to this email directly, view it on GitHub https://github.com/crisp-im/node-crisp-api/issues/55, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGTRQ542WOEM5WHSUFSBHTXWS7ARANCNFSM6AAAAAA32AXA4I. You are receiving this because you are subscribed to this thread.

QuentinFarizon commented 1 year ago

I prefer not, this is very impacting. Please fix the issue

eliottvincent commented 1 year ago

Fixed in 8.0.2, closing.