Closed RussBainer closed 4 months ago
Hi @RussBainer, taking a look at it right now
Pushed a fix; let me know if that works
Sorry @Jfortin1 ! I just realized that my github notifications were going to my old work email.
This looks like a good fix. Thanks!
Hi JP and Team, really enjoying this set of tools.
I've run into an error from the
addEditingWeights()
function that occurs when the targeted sequence doesn't have any nucleotides with values greater than zero in the base editor weight matrix.I'm not sure how you'd want to address circumstances like this in terms of the functionality of the code, so I thought I'd raise it as an issue instead of a PR. I think you can resolve it on line 220 of
addEditedAlleles.R
by checkinglength(nNucs) > 0
. For example: