search

crisptrutski / boot-cljs-test

Boot task to run ClojureScript tests.
53 stars 18 forks source link

permit doo options to be set #47

Closed loomis closed 7 years ago

loomis commented 8 years ago

I've run into a situation in which I need to set the command line options for the phantomjs runner, specifically I need to turn off the web security for a set of tests that hit an external server. Doo provides the ability to do this via the :paths option, but there is no way to feed this through the current version of the test-cljs task.

I currently have a fork where the doo options can be set. These options are simply merged into the options passed to run-script (currently only :ext-dir). If that is acceptable, I can create a PR for the change.

crisptrutski commented 8 years ago

That sounds pretty sensible, such a PR would be welcome!

loomis commented 8 years ago

PR provided (#49). The automated tests have passed and there are currently no merge conflicts.