search

crisptrutski / boot-cljs-test

Boot task to run ClojureScript tests.
53 stars 18 forks source link

NPE running Node tests on Windows #51

Closed anmonteiro closed 7 years ago

anmonteiro commented 7 years ago

This is probably related to #31, but I'm not certain if it's specific to having external Node modules or just running Node tests on Windows.

Here's a stack trace: https://ci.appveyor.com/project/anmonteiro/lumo/build/1.0.123

crisptrutski commented 7 years ago

Thanks for the report, and having the stacktrace is invaluable. Looks like a general windows bug I've introduced by changing the build id to include a directory separator.

crisptrutski commented 7 years ago

@anmonteiro Please let me know if anything changes with the snapshot I've just deployed 😄

anmonteiro commented 7 years ago

@crisptrutski I think it passes the new guard but fails in a subsequent one: https://ci.appveyor.com/project/anmonteiro/lumo/build/1.0.128

anmonteiro commented 7 years ago

Shouldn't the output dir be there in any case? Can't Boot-cljs-test find paths with \ too?

crisptrutski commented 7 years ago

I need to add more guards, but that's not the fix, that's just to reach the "nice" error on line 130.

Need to figure out why the file isn't matching. Could replace the string with a regex that's OS agnostic.. but don't see how that's any different to just setting the right separator in the string..

crisptrutski commented 7 years ago

It's quite late here and I'm off to sleep, print-debugging the paths seems the simplest, maybe something obviously different about the fileset paths on windows.

crisptrutski commented 7 years ago

@anmonteiro did you get anywhere with this? also curious if setting a single segment id still works around this issue.

anmonteiro commented 7 years ago

I didn't investigate it, if that's what you're asking. as for the single segment, I can only say that 0.2.2 works fine.

crisptrutski commented 7 years ago

OK, will set myself up with some *doze and debug as soon as I get a chance :)

Perhaps try :ids ["output"] as an option, that should match 0.2.2's single segment runner namespace.

anmonteiro commented 7 years ago

@crisptrutski a single segment ID definitely did the trick. so we know that's the problem at least :-) thanks!

crisptrutski commented 7 years ago

Should be hunky dory now 😄

anmonteiro commented 7 years ago

awesome, did you deploy a snapshot?

crisptrutski commented 7 years ago

Yip it's pushed