search

crisptrutski / boot-cljs-test

Boot task to run ClojureScript tests.
53 stars 18 forks source link

Regex error with latest version #69

Closed arichiardi closed 7 years ago

arichiardi commented 7 years ago

Hello folks!

I got an error in lumo's latest build in appveyor (windows):

                              java.lang.Thread.run              Thread.java:  745
java.util.concurrent.ThreadPoolExecutor$Worker.run  ThreadPoolExecutor.java:  617
 java.util.concurrent.ThreadPoolExecutor.runWorker  ThreadPoolExecutor.java: 1142
               java.util.concurrent.FutureTask.run          FutureTask.java:  266
                                               ...                               
               clojure.core/binding-conveyor-fn/fn                 core.clj: 2027
                                 boot.core/boot/fn                 core.clj: 1031
                               boot.core/run-tasks                 core.clj: 1021
      crisptrutski.boot-cljs-test/eval773/fn/fn/fn       boot_cljs_test.clj:  238
crisptrutski.boot-cljs-test/-prep-cljs-tests/fn/fn       boot_cljs_test.clj:  155
      crisptrutski.boot-cljs-test/ensure-suite-ns!       boot_cljs_test.clj:  127
        crisptrutski.boot-cljs-test.utils/file->ns                utils.clj:   38
                           clojure.core/re-pattern                 core.clj: 4773
                   java.util.regex.Pattern.compile             Pattern.java: 1028
                    java.util.regex.Pattern.<init>             Pattern.java: 1351
                   java.util.regex.Pattern.compile             Pattern.java: 1702
                     java.util.regex.Pattern.error             Pattern.java: 1955
java.util.regex.PatternSyntaxException: Unexpected internal error near index 1
                                        \
                                         ^
    description: "Unexpected internal error"
          index: 1
        pattern: "\\"
            clojure.lang.ExceptionInfo: Unexpected internal error near index 1
                                        \
                                         ^
    line: 220

Hopefully just a simple fix?

crisptrutski commented 7 years ago

Indeed this looks like a silly oversight on my behalf - bad hygiene with dynamic regexes. Fixin'

Would you recommend appveyor for adding some windows regression tests directly to boot-cljs-test?

crisptrutski commented 7 years ago

https://clojars.org/crisptrutski/boot-cljs-test/versions/0.3.4-SNAPSHOT

anmonteiro commented 7 years ago

@crisptrutski I would definitely recommend Appveyor. We've been using it for Lumo's Windows tests and I love it. Trying the snapshot version right now in https://github.com/anmonteiro/lumo/pull/253

crisptrutski commented 7 years ago

Thanks for sharing - and glad to see it's green again 😄