crissNb / Dynamic-Island-Sketchybar

Dynamic Island on iPhone 14 Pro implementation on Mac using Sketchybar
MIT License
438 stars 23 forks source link

item.sh Overriding Sketchybarrc Bar properties #35

Closed khaneliman closed 1 year ago

khaneliman commented 1 year ago

Hey, I noticed that there was a commit for adding the sketchybar --bar config to the item.sh. It will override a user's sketchybarrc config changing the layout/theme of their actual sketchybar bar instead of just the dynamic island. I think I see the intention and just wanted to verify and see if we could utilize variables instead of hard coding some values to support user customization.

Without sketchybar --bar commit: (custom offsets and theming)

image

With sketchybar --bar commit: (anchored to top and transparent)

image

I assume the intention was to try and make the dynamic island come from the actual top of the screen and be invisible until invoked?

crissNb commented 1 year ago

There had to be some --bar config and --defaults configured when the user would like to use the Dynamic Island without any other sketchybarrc modules. But I agree, it makes sense that the --bar settings conflict for existing users.

A solution that I'm thinking for a while for this is to have the Dynamic Island running as an another instance of SketchyBar (using its multi-bar support). This way the Dynamic Island will be consistent across all existing Sketchybar users. There also won't be a need to edit the existing sketchybarrc.

khaneliman commented 1 year ago

So it looks like we just need to tell user to clone into a separate config directory and do a custom symlink or create a simple bootstrapping script. ln -s $(which sketchybar) $(dirname $(which sketchybar))/dynamic-island-sketchybar && git clone https://github.com/crissNb/Dynamic-Island-Sketchybar.git ~/.config/dynamic-island-sketchybar

crissNb commented 1 year ago

I've made the Dynamic Island separate from the regular SketchyBar config. It seems to work fine on my end. Could you let me know if there's still problem on your end?

khaneliman commented 1 year ago

I've made the Dynamic Island separate from the regular SketchyBar config. It seems to work fine on my end. Could you let me know if there's still problem on your end?

Sorry, haven't used my laptop in a few days. Latest commit works well for me with keeping my standard bar config in tact and the dynamic island looks better now too since it's anchored where it wants to be.