crissNb / Dynamic-Island-Sketchybar

Dynamic Island on iPhone 14 Pro implementation on Mac using Sketchybar
MIT License
411 stars 22 forks source link

Spotify support for music component #8

Closed zcag closed 1 year ago

zcag commented 1 year ago

Is this planned?

Great stuff btw, really looking forward to see how this evolves

crissNb commented 1 year ago

Yes it is, I'll be looking into implementing it on this weekend.

zcag commented 1 year ago

@crissNb if i set the P_DYNAMIC_ISLAND_MUSIC_SOURCE=Spotify and echo P_DYNAMIC_ISLAND_MUSIC_SOURCE and MUSIC_SOURCE both of them gets set to 'Music' after the first echo output. Was this working on your end? I'm investigating the issue, just wanted to inform.

crissNb commented 1 year ago

It doesn't seem to be working on my end either (I thought it was fine when I tested it? I'm not sure what happened). Did you find a fix for this? Otherwise I'll be looking into solving this tomorrow

zcag commented 1 year ago

my guess is it's because we're not passing env variables correctly in some place, possible in reset.sh or something, i couldn't find any decent cause though, waiting until i have more spare time

112cxyz commented 1 year ago

I've made a osascript for Spotify work and I could look into making it work

crissNb commented 1 year ago

@112cxyz Will you be making a PR soon (which will be absolutely awesome)? Otherwise I could look into solving this problem myself when I have spare time

112cxyz commented 1 year ago

I will be later I’m just trying to fix random lag and also random bugs with non downloaded album art. I have quite a busy day today but I’ll do it as soon as I can

On Wed, 26 Oct 2022 at 07:56, crissNb @.***> wrote:

@112cxyz https://github.com/112cxyz Will you be making a PR soon (which will be absolutely awesome)? Otherwise I could look into solving this problem myself when I have spare time

— Reply to this email directly, view it on GitHub https://github.com/crissNb/Dynamic-Island-Sketchybar/issues/8#issuecomment-1291583329, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZFFQFPCJGHIBHKCHLRTXTWFDIY3ANCNFSM6AAAAAARDVBHIU . You are receiving this because you were mentioned.Message ID: @.***>

crissNb commented 1 year ago

Spotify seems to be working as intended after config rework, 99cdd84 (or at least on my end). Closing this issue for now