search

cristian64 / mkdd-extender

A tool for extending Mario Kart: Double Dash!! with extra courses.
GNU General Public License v3.0
18 stars 4 forks source link

Provide option to use system theme on Linux #4

Open Miepee opened 1 year ago

Miepee commented 1 year ago

It would be nice, if on Linux there was an option for the QT interface to use the system's QT theme, instead of the one provided by the application.

cristian64 commented 1 year ago

Adding an option to opt-out of the dark style would be possible, but there are a number of images (and a few other hardcoded colors) that may not fit well. Without being capable of ensuring that it would look well in all desktop environments, I'm reluctant to add the preference.

With a development checkout, one can neutralize the set_dark_theme() function to stop applying the dark style. Happy to see screenshots of how the default theme would look like on other desktop environments, to determine whether it's worth it. (May need to drop the "Fusion" style too.)

Miepee commented 1 year ago

Here it is running on my normal KDE install with Breeze: grafik

Here it is with a gnome-like theme: grafik

In both cases they look at least like they belong into vanilla KDE and vanilla GNOME respectively, with the exception from a few outliers. I didn't test any light themes, but icons there should be fixable by just giving them all a black outline i think.

Without being capable of ensuring that it would look well in all desktop environments, I'm reluctant to add the preference.

This is impossible to do. Desktop Environments don't actually impact the theme, so it's up to the distribution or user to select the theme. And since QT themes are all modifiable there really is no way for you to make sure that your app won't break if some goofball makes a qt theme where everything is pink or something. So IMO an option to use the system theme would be ok, as long as the user understands that if they don't use your theme, they're essentially on unsupported territory.