search

cristianbote / bundlephobia-extension

Bundlephobia Web Extension
https://chrome.google.com/webstore/detail/bundlephobia-web-extension/dliifhggbnajibohfjcpiedlfjmoneko
14 stars 3 forks source link

Add support for scoped packages #5

Open micahjon opened 5 years ago

micahjon commented 5 years ago

First of all, thanks for this super nifty extension.

I noticed it wasn't working well for scoped packages: @orgname/packagename https://www.npmjs.com/package/@babel/core https://www.npmjs.com/package/@webcomponents/template

So I forked it and tweaked getPackageName() to handle this case. If you'd like me to submit a PR, I'd be happy to. https://github.com/pranksinatra/bundlephobia-extension/commit/eb4066be3baf952f0b404a69561d965f298003b7

cristianbote commented 5 years ago

Hey @pranksinatra thanks for submitting this really appreciate it! 😄 It looks awesome! Feel free to open a PR when you're ready. Looking forward!

micahjon commented 5 years ago

Sweet, just submitted PR #6